Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stack View Animation #4799

Merged
merged 14 commits into from
Feb 13, 2025
Merged

fix: Stack View Animation #4799

merged 14 commits into from
Feb 13, 2025
+27 −14

Conversation

Resaki1
Copy link
Collaborator

@Resaki1 Resaki1 commented Jan 22, 2025

Description

Due to changes in the stack view layout, the animation that appears when navigating between notes was a little broken. This has been fixed. Includes minor code improvements.

Changelog

There were three issues with the animation:

  1. The width of the container was limited with overflow: hidden, meaning the notes were cut off left and right during the animation.
  2. When navigating between stacks with a different number of stacked notes, the height of the container would change instantly at the start of the animation, cutting the notes off at the bottom.
  3. When navigating between columns, the previous stack would instantly disappear.

These issues have been fixed, as shown below:

Visual Changes

Before

Bildschirmaufnahme.2025-01-22.um.16.06.37.mov

After

Bildschirmaufnahme.2025-01-22.um.16.05.45.mov

@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
Schwehn42
Schwehn42 reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throws an error in Firefox 134.0.2 when trying to transition between columns:

Firefox column transition error

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Jan 23, 2025
@Resaki1
Copy link
Collaborator Author

Resaki1 commented Jan 23, 2025

throws an error in Firefox 134.0.2 when trying to transition between columns:

Firefox column transition error

Oops, I forgot that Firefox does not support the View Transition API. Should be fixed now, thanks

@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@Resaki1 Resaki1 added Review Needed This pull request is ready for review and removed Changes Requested Changes requested by the reviewer labels Jan 27, 2025
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@Schwehn42 Schwehn42 added Changes Requested Changes requested by the reviewer and removed Review Needed This pull request is ready for review labels Feb 11, 2025
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@Resaki1 Resaki1 added Review Needed This pull request is ready for review and removed Changes Requested Changes requested by the reviewer labels Feb 12, 2025
Schwehn42
Schwehn42 reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug; In mobile view, a stack with multiple notes is no longer scrollable

@Schwehn42 Schwehn42 added Changes Requested Changes requested by the reviewer and removed Review Needed This pull request is ready for review labels Feb 12, 2025
@github-actions GitHub Actions
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4799.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images

  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-c3a7a03

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-c3a7a03

@octomind-dev OctoMind-dev
Copy link

octomind-dev bot commented Feb 12, 2025 •
edited
Loading

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: c3a7a03

@Resaki1
Copy link
Collaborator Author

Resaki1 commented Feb 12, 2025

Found a bug; In mobile view, a stack with multiple notes is no longer scrollable

thanks, should be fixed now

Schwehn42
Schwehn42 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now, lgtm 👍

@Schwehn42 Schwehn42 removed the Changes Requested Changes requested by the reviewer label Feb 13, 2025
@Resaki1 Resaki1 added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 4b9274e Feb 13, 2025
13 checks passed
@Resaki1 Resaki1 deleted the cr/fix-stackview-animation branch February 13, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schwehn42 Schwehn42 Schwehn42 approved these changes

@brandstetterm brandstetterm Awaiting requested review from brandstetterm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Resaki1 @Schwehn42 @brandstetterm @Lennart01